Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): adding tz offset to dates #308

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

lucasbracher
Copy link
Collaborator

@lucasbracher lucasbracher commented Sep 16, 2024

Adds timezone offset to dates at main page and other places:

Before After
Screenshot from 2024-09-16 11-21-15 image

Closes #305

@lucasbracher lucasbracher force-pushed the feat/305_timezones_on_all_datetimes branch 2 times, most recently from 8aad243 to 8bf37fb Compare September 16, 2024 22:46
@lucasbracher lucasbracher marked this pull request as ready for review September 16, 2024 22:47
@lucasbracher lucasbracher force-pushed the feat/305_timezones_on_all_datetimes branch from 8bf37fb to c632d37 Compare September 17, 2024 12:18
@lucasbracher lucasbracher requested review from lfjnascimento and WilsonNet and removed request for lfjnascimento September 17, 2024 12:22
@loadez
Copy link
Collaborator

loadez commented Sep 17, 2024

There is a mismatch in the tree details execution list date and the build details build time.

image

image

@lucasbracher lucasbracher force-pushed the feat/305_timezones_on_all_datetimes branch from 312957d to 8c2f2a7 Compare September 20, 2024 16:02
@lucasbracher lucasbracher force-pushed the feat/305_timezones_on_all_datetimes branch 2 times, most recently from 479df36 to f42eaff Compare September 20, 2024 16:26
Copy link
Collaborator

@WilsonNet WilsonNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job

@lucasbracher lucasbracher force-pushed the feat/305_timezones_on_all_datetimes branch from f42eaff to f384e29 Compare September 20, 2024 17:11
Now tooltip shows right date and time.

Closes #318
@lucasbracher lucasbracher force-pushed the feat/305_timezones_on_all_datetimes branch from f384e29 to 4aac24a Compare September 20, 2024 17:16
@lucasbracher lucasbracher merged commit 4aac24a into main Sep 20, 2024
4 checks passed
@WilsonNet WilsonNet deleted the feat/305_timezones_on_all_datetimes branch October 24, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants