feat(dashboard): lighter red for 0 errors #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbracher
force-pushed
the
feat/316_clearer_red_on_zero_errors
branch
from
babd54e
to
1917b76
Compare
WilsonNet
reviewed
Sep 18, 2024
lucasbracher
force-pushed
the
feat/316_clearer_red_on_zero_errors
branch
2 times, most recently
from
db68aec
to
b6c576a
Compare
WilsonNet
reviewed
Sep 19, 2024
WilsonNet
approved these changes
Sep 19, 2024
Comment on lines
43
to
47
| const clearerCircles = | ||
| quantity == 0 && | ||
| (tooltipText == 'global.failed' || tooltipText == 'global.inconclusive') | ||
| ? 'bg-opacity-20' | ||
| : ''; |
There was a problem hiding this comment.
Maybe we can put this behavior in every circle not just for failed or inconclusive IMO that will improve consistency
There was a problem hiding this comment.
If we can't, create a fadeOnEmpty prop for the component as tooltipText is not a suitable value for this.
There was a problem hiding this comment.
I think the same, but ticket's title is clear.
|
Got back to 40% opacity because %20 was harder in order to distinct gray and lighest red: On 20% opacity:
On 40% opacity:
|
lfjnascimento
approved these changes
Sep 19, 2024
lucasbracher
force-pushed
the
feat/316_clearer_red_on_zero_errors
branch
from
b6c576a
to
96c292c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves visibility of zeroed errors.
Closes #316