Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add items per page selector in TableInfo #327

Closed
wants to merge 0 commits into from
Closed

feat: add items per page selector in TableInfo #327

wants to merge 0 commits into from

Conversation

lfjnascimento
Copy link
Collaborator

Before After
image image

Close: #175

@lfjnascimento lfjnascimento self-assigned this Sep 20, 2024
loadez
loadez approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@loadez loadez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems alright.

I would like to have the pagination and items per page in the url but that would cause problems when navigating to new pages. So LGTM.

@lfjnascimento
Copy link
Collaborator Author

Everything seems alright.

I would like to have the pagination and items per page in the url but that would cause problems when navigating to new pages. So LGTM.

I understand your consideration, the problem is that our URL is getting huge, we have to be more restrictive with what we put in the URL.

WilsonNet
WilsonNet approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@WilsonNet WilsonNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@lfjnascimento lfjnascimento deleted the feat/quantity_selector branch October 24, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilsonNet WilsonNet WilsonNet approved these changes

@loadez loadez loadez approved these changes

Assignees

@lfjnascimento lfjnascimento

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Items per page in the paginated tab does not work
3 participants
@lfjnascimento @loadez @WilsonNet