Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add filter by hardware #426

Merged
merged 1 commit into from
Oct 25, 2024
Merged

feat: add filter by hardware #426

merged 1 commit into from
Oct 25, 2024

Conversation

anajalvarenga
Copy link
Contributor

@anajalvarenga anajalvarenga commented Oct 24, 2024 •
edited
Loading

Add filter by hardware and fix filter errors

How to test

  1. got to http://localhost:5173/tree/7678c1b2735a048774c98c2d3b6b4718762c8570?tableFilter=%7B%22buildsTable%22%3A%22all%22%2C%22bootsTable%22%3A%22all%22%2C%22testsTable%22%3A%22all%22%7D&origin=maestro&currentTreeDetailsTab=treeDetails.builds&diffFilter=%7B%7D&treeInfo=%7B%22gitBranch%22%3A%22for-kernelci%22%2C%22gitUrl%22%3A%22https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Farm64%2Flinux.git%22%2C%22treeName%22%3A%22arm64%22%2C%22commitName%22%3A%22v6.12-rc4-141-g7678c1b2735a%22%2C%22headCommitHash%22%3A%227678c1b2735a048774c98c2d3b6b4718762c8570%22%7D
  2. try to apply some filters
  3. got to http://localhost:5173/tree/e9001a382fa2c256229adc68d55212028b01d515?tableFilter=%7B%22buildsTable%22%3A%22all%22%2C%22bootsTable%22%3A%22all%22%2C%22testsTable%22%3A%22all%22%7D&origin=redhat&currentTreeDetailsTab=treeDetails.tests&diffFilter=%7B%7D&treeInfo=%7B%22gitBranch%22%3A%22master%22%2C%22gitUrl%22%3A%22https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Fvirt%2Fkvm%2Fkvm.git%22%2C%22treeName%22%3A%22kvm%22%2C%22commitName%22%3A%22for-linus-30-ge9001a382fa2%22%2C%22headCommitHash%22%3A%22e9001a382fa2c256229adc68d55212028b01d515%22%7D
  4. try to apply some test duration filters

@anajalvarenga anajalvarenga marked this pull request as ready for review October 24, 2024 22:14
MarceloRobert
MarceloRobert reviewed Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@MarceloRobert MarceloRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but some of the hardware filters seem to not be working, they are listed as tested hardware but when the filter is applied it retrieves 0 boots/tests. This makes it so that even when every hardware is selected in the filters, the return is less than using no filters.

This was referenced Oct 25, 2024
Merged
Closed
Francisco2002
Francisco2002 reviewed Oct 25, 2024
View reviewed changes
dashboard/src/api/TreeDetails.tsx Outdated
);
filterList?.forEach(value => {
if (!filterParam[`filter_${key}`])
return (filterParam[`filter_${key}`] = [value.toString()]);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need this return statement.

dashboard/src/api/TreeDetails.tsx Outdated
filterList?.forEach(value => {
if (!filterParam[`filter_${key}`])
return (filterParam[`filter_${key}`] = [value.toString()]);
return filterParam[`filter_${key}`].push(value.toString());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto about return statement

@Francisco2002
Copy link
Collaborator

The hardware filters looks good!!
But the others filters in Build Tab were broken when I select more than one filter by field.

Wrong Correct
errado correto
errado correto
errado correto
errado correto

@anajalvarenga anajalvarenga mentioned this pull request Oct 25, 2024
Closed
@anajalvarenga
Copy link
Contributor Author

The hardware filters looks good!! But the others filters in Build Tab were broken when I select more than one filter by field.

Wrong Correct
errado correto
errado correto
errado correto
errado correto

I create a new issue for this bug #438

MarceloRobert
MarceloRobert approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@MarceloRobert MarceloRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well!

@anajalvarenga anajalvarenga merged commit 8e14bc1 into main Oct 25, 2024
5 checks passed
@Francisco2002 Francisco2002 mentioned this pull request Oct 30, 2024
Merged
@WilsonNet WilsonNet deleted the feat/add-filter-by-hardware branch November 13, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Francisco2002 Francisco2002 Francisco2002 left review comments

@MarceloRobert MarceloRobert MarceloRobert approved these changes

@lfjnascimento lfjnascimento lfjnascimento approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add filter by environment compatible
4 participants
@anajalvarenga @Francisco2002 @lfjnascimento @MarceloRobert