feat/hardware listing backend #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
29
to
34
| if test["build__valid"] is None: | ||
| hardware[compatible]["buildCount"]["null"] += 1 | ||
| elif test["build__valid"] is True: | ||
| hardware[compatible]["buildCount"]["valid"] += 1 | ||
| else: | ||
| hardware[compatible]["buildCount"]["invalid"] += 1 |
There was a problem hiding this comment.
just a nit but you can create a reusable map in utils for build status
build_status_map = {True: 'valid', False: 'invalid', None: 'null'}
# and then
build_status = build_status_map[test["build__valid"]] # or using a function get_build_status(...)
hardware[compatible]["buildCount"][build_status] += 1| hardwares = set() | ||
| tests = Tests.objects.filter( | ||
| start_time__gte=start_date, environment_compatible__isnull=False | ||
| ).values("environment_compatible", "start_time") |
There was a problem hiding this comment.
not using start_time here
Comment on lines
55
to
61
| try: | ||
| daysInterval = int(request.GET.get("daysInterval", 3)) | ||
| except ValueError: | ||
| return JsonResponse({"error": "Invalid daysInterval"}, status=400) | ||
|
|
||
| if daysInterval < 1: | ||
| return JsonResponse({"error": "Invalid daysInterval"}, status=400) |
There was a problem hiding this comment.
we are using this logic in 3 different queries, let's create a function to handle this
| def get(self, request): | ||
| mode = request.GET.get("mode", "fast") | ||
| try: | ||
| daysInterval = int(request.GET.get("daysInterval", 3)) |
There was a problem hiding this comment.
I would either move this logic to a separate function as @lfjnascimento said or use the same variable name as it is in treeView and treeViewFast (interval_days for the variable and intervalInDays for the url parameter)
There was a problem hiding this comment.
Also, use a const for the default daysInterval instead of a magic number
Added two new scripts for hardware listing: - hardware-listing-fast.sh for fast mode - hardware-listing-slow.sh for slow mode These scripts make HTTP requests to the hardware API endpoint with different modes. Part of #445
- Added a new URL pattern for the hardware endpoint in `urls.py`. - Created `HardwareView` in `views/hardwareView.py` to handle hardware data. - Implemented `__getSlowResult` and `__getFastResult` methods to fetch hardware data based on the mode. - Added error handling for invalid `daysInterval` and `mode` parameters. Closes #445
WilsonNet
force-pushed
the
feat/hardware-listing
branch
from
57004fa
to
d5425a9
Compare
- Added build_status_map to map build status to string values. - Implemented parseIntervalInDaysGetParameter to parse and validate intervalInDays parameter. - Created ExceptionWithJsonResponse class to handle exceptions with JSON responses. Part of #445
- Replaced `daysInterval` with `intervalInDays` in `hardwareDetailsView.py` and `treeView.py`. - Updated import statements to include `parseIntervalInDaysGetParameter` and `ExceptionWithJsonResponse`. - Modified `hardware.sh` to use the new `intervalInDays` parameter. - Adjusted error handling to use `ExceptionWithJsonResponse` for better consistency.
WilsonNet
force-pushed
the
feat/hardware-listing
branch
from
d5425a9
to
9b40060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add endpoints for the hardware listing page:
This PR adds the endpoint for the hardware listing page, it adds both a fast and slow view that are accessed via query parameters.
How to test