Support stripping metadata #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return NotImplemented from comparison methods, as is standard approach, instead of raising NotImplementedError, in the abstract schema.
Check that the compared value is a type in the abstract schema's comparison methods, otherwise we'll get an exception from issubclass(), when it's not.
spbnick
force-pushed
the
support_stripping_metadata
branch
from
7e29b84
to
64d8080
Compare
|
Let's wait for the corresponding kcidb run: https://github.com/kernelci/kcidb/actions/runs/9173354252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for stripping metadata from I/O data. There's no real need for that right now, but it could come in useful.
This also includes a couple minor fixes.