Skip to content

Commit

Permalink
stable-rc: fix empty BOOT TESTS section
Browse files Browse the repository at this point in the history
Fix issue of empty section for boot failures.
This was due to use of incorrect test node field
for getting `platform` information.
Use `environment.misc.platform` to fix the issue.
Also, display the below message when boot
failures are found without failure information:
```
Boot failures found but failure information missing
```

Signed-off-by: Jeny Sadadia <[email protected]>
  • Loading branch information
Jeny Sadadia authored and spbnick committed Aug 8, 2024
1 parent 6cdb8e7 commit f1619d7
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions kcidb/templates/stable_rc_test.j2
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,23 @@
{% macro container_summary(container, max_list_len) %}
{{- "\nBOOT TESTS" }}
{% if container.tests %}
{% set failed_boot_tests = container.tests_root["boot"].waived_status_tests[false]["FAIL"] %}
{% set failed_boot_tests = container.tests_root["boot"].waived_status_tests[false]["FAIL"] |
selectattr('origin', 'in', stable_rc_macros.selected_origins) | list %}
{% if failed_boot_tests %}
{{- "\n Failures" }}
{% for origin, boot_tests in failed_boot_tests|groupby("origin") %}
{% if origin in stable_rc_macros.selected_origins %}
{% for architecture, tests in boot_tests|groupby("build.architecture") %}
{% set device_list = tests | selectattr('misc.platform', 'defined') | list %}
{% if device_list %}
{{- " " + architecture }}:({{ tests|map(attribute="build.config_name") | unique | join("") }})
{% endif %}
{% for device in device_list %}
{{- " -" + device.misc.platform }}
{% set boot_tests_info = boot_tests | selectattr('environment_misc.platform', 'defined') | list %}
{% if boot_tests_info %}
{% for architecture, tests in boot_tests_info|groupby("build.architecture") %}
{{- " " + architecture }}:({{ tests|map(attribute="build.config_name") | unique | join("") }})
{% for test in tests %}
{{- " -" + test.environment_misc.platform }}
{% endfor %}
{% endfor %}
{{- " CI system: " + origin + "\n" }}
{% else %}
{{- "\n Missing failure information. Sorry, we are working on improving report for this situation." }}
{{- "\n CI system: " + origin + "\n" }}
{% endif %}
{% endfor %}
{% else %}
Expand Down

0 comments on commit f1619d7

Please sign in to comment.