Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved empty_deployment fixture to session scope in conftest #440

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Moved empty_deployment fixture to session scope in conftest #440

merged 1 commit into from
Jul 25, 2023

Conversation

octonawish-akcodes
Copy link
Contributor

@octonawish-akcodes octonawish-akcodes commented Jul 23, 2023 •
edited
Loading

Need reviews @spbnick

@octonawish-akcodes octonawish-akcodes temporarily deployed to staging July 23, 2023 18:52 — with GitHub Actions Inactive
spbnick
spbnick reviewed Jul 24, 2023
View reviewed changes
conftest.py Outdated Show resolved Hide resolved
@octonawish-akcodes octonawish-akcodes temporarily deployed to staging July 24, 2023 12:53 — with GitHub Actions Inactive
spbnick
spbnick approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@spbnick spbnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please use imperative mood for your commit messages next time. I.e. write "Move", not "Moved". Thank you!

@spbnick spbnick merged commit a2f8d85 into main Jul 25, 2023
5 checks passed
@spbnick spbnick deleted the C branch July 25, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spbnick spbnick spbnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@octonawish-akcodes @spbnick