Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud: Add updated_urls_topic to cloud function env #441

Merged
merged 1 commit into from
Jul 26, 2023
Merged

cloud: Add updated_urls_topic to cloud function env #441

merged 1 commit into from
Jul 26, 2023

Conversation

octonawish-akcodes
Copy link
Contributor

Added updated_urls_topic to the cloud function environment.

Need reviews @spbnick

Copy link
Collaborator

@spbnick spbnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, with one naming comment inline, but please actually pass the topic name to the function, from execute_command().

cloud Outdated Show resolved Hide resolved
@spbnick
Copy link
Collaborator

spbnick commented Jul 26, 2023

LGTM! Thank you, Abhishek.

@spbnick
Copy link
Collaborator

spbnick commented Jul 26, 2023

Let's wait for CI to finish.

@octonawish-akcodes
Copy link
Contributor Author

Let's wait for CI to finish.

Okay

@spbnick spbnick merged commit 2e6e038 into main Jul 26, 2023
5 checks passed
@spbnick spbnick deleted the E branch July 26, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants