Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloud: Add cache_redirector function #447

Merged
merged 1 commit into from
Aug 6, 2023
Merged

cloud: Add cache_redirector function #447

merged 1 commit into from
Aug 6, 2023

Conversation

octonawish-akcodes
Copy link
Contributor

@octonawish-akcodes octonawish-akcodes commented Jul 27, 2023 •
edited
Loading

Added cache redirection server function.

Need reviews @spbnick

@octonawish-akcodes octonawish-akcodes temporarily deployed to staging July 28, 2023 18:57 — with GitHub Actions Inactive
spbnick
spbnick requested changes Jul 31, 2023
View reviewed changes
main.py Outdated Show resolved Hide resolved
main.py Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
@octonawish-akcodes octonawish-akcodes temporarily deployed to staging August 4, 2023 05:45 — with GitHub Actions Inactive
spbnick
spbnick requested changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@spbnick spbnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit message to match your change.

main.py Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
spbnick
spbnick previously approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@spbnick spbnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at it for a while, let's not change anything else, for now. So, it's good to go in.

However, have you tested that it works?

spbnick
spbnick reviewed Aug 4, 2023
View reviewed changes
main.py Outdated Show resolved Hide resolved
@octonawish-akcodes octonawish-akcodes temporarily deployed to staging August 4, 2023 15:55 — with GitHub Actions Inactive
tales-aparecida
tales-aparecida reviewed Aug 4, 2023
View reviewed changes
main.py Outdated Show resolved Hide resolved
@octonawish-akcodes octonawish-akcodes temporarily deployed to staging August 4, 2023 17:34 — with GitHub Actions Inactive
@spbnick
Copy link
Collaborator

spbnick commented Aug 6, 2023

LGTM, thank you, Abhishek.

However, please squash all commits into one ("cloud: Add kcidb_cache_redirect function"), as we don't need them without it.

@octonawish-akcodes
Copy link
Contributor Author

@spbnick Done

@octonawish-akcodes octonawish-akcodes temporarily deployed to staging August 6, 2023 14:00 — with GitHub Actions Inactive
@spbnick spbnick merged commit 5415713 into main Aug 6, 2023
5 checks passed
@spbnick spbnick deleted the I branch August 6, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tales-aparecida tales-aparecida tales-aparecida left review comments

@spbnick spbnick spbnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@octonawish-akcodes @spbnick @tales-aparecida