Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache: Remove one 0 from hash name check to cache more URLs #469

Merged
merged 1 commit into from
Aug 25, 2023
Merged

cache: Remove one 0 from hash name check to cache more URLs #469

merged 1 commit into from
Aug 25, 2023

Conversation

octonawish-akcodes
Copy link
Contributor

No description provided.

spbnick
spbnick reviewed Aug 25, 2023
View reviewed changes
kcidb/cache/__init__.py Outdated Show resolved Hide resolved
spbnick
spbnick requested changes Aug 25, 2023
View reviewed changes
kcidb/cache/__init__.py Outdated Show resolved Hide resolved
@octonawish-akcodes
Copy link
Contributor Author

done

spbnick
spbnick approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@spbnick spbnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, Abhishek. Let's see how CI behaves. Those changed hash requirements could have affected tests.

@octonawish-akcodes octonawish-akcodes temporarily deployed to staging August 25, 2023 13:39 — with GitHub Actions Inactive
@spbnick spbnick merged commit fdbfca7 into main Aug 25, 2023
5 checks passed
@spbnick spbnick deleted the T branch August 25, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spbnick spbnick spbnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@octonawish-akcodes @spbnick