-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support v4.4 I/O schema #529
base: main
Are you sure you want to change the base?
Conversation
9118b53
to
4816023
Compare
@hardboprobot, here's the preliminary support for our draft v4.4 I/O schema. Deployment tests are still running, but it should be sufficient to create a database, and start submitting "transitions". We can make a development/test deployment in staging for us to play with. We can start with generating the transitions using SQL directly, and then see whether we can/need to implement the ORM support for it. Please review! |
This attempts to separate the "dummy" support for the schema from the actual database support. However, I haven't tested yet if it would work. Will do that later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are so many things here I'm not familiar with that I can't really say anything other than if you're ok with the changes and they're tested and work, then it's fine by me. I like the plan, let me know when I can jump in to play with transitions and detections.
4816023
to
eb6cbb3
Compare
No problem! I just wanted you to take a look to get a feel for it, and tell me if you spotted anything weird. Would you like to have a call and go over how to do a deployment, get a data sample, load it up, and so on? Or would you prefer I do all that for you and just give you the database credentials? In any case once you've got a feel for the schema and tried implementing the analysis, we can get on with implementing it in KCIDB. As a hardcoded function, for example, for the start. |
No description provided.