Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kcidb/oo: remove a build error pattern #555

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

JenySadadia
Copy link
Collaborator

The below build log isn't an actual error message: Build script is completed, tail will be killed now. Hence, remove the related pattern from the list of build errors.

The below build log isn't an actual error message:
`Build script is completed, tail will be killed now`.
Hence, remove the related pattern from the list
of build errors.

Signed-off-by: Jeny Sadadia <[email protected]>
@JenySadadia
Copy link
Collaborator Author

@crazoes I am wondering what should be the actual build error log for the report for failures such as https://kcidb.kernelci.org/d/build/build?orgId=1&var-id=maestro:66b399764ec9bd2e74797ca8.

@JenySadadia JenySadadia requested a review from spbnick August 8, 2024 09:45
@JenySadadia
Copy link
Collaborator Author

Looks like the build was completed successfully and somehow reported with fail result to KCIDB:
https://kernelci-api.westus3.cloudapp.azure.com/viewer?node_id=66b399764ec9bd2e74797ca8

@nuclearcat
Copy link
Member

Probably it did timeout due overload of build cluster:

 "error_code": "node_timeout",
    "error_msg": "Node timed-out",

So we need to delete error_code and msg when build complete.

@crazoes
Copy link

crazoes commented Aug 8, 2024

@JenySadadia these are false positives and maybe the kernel build isn't failing but the kselftest build is failing here. I have asked @musamaanjum to work on fixing these issues. You can check more details here :- https://github.com/orgs/kernelci/projects/22/views/1?pane=issue&itemId=72345288

@JenySadadia
Copy link
Collaborator Author

@crazoes The issue is from the KCIDB bridge side.
When the node times out, we send it with FAIL status as KCIDB doesn't have incomplete/miss for build results.
@spbnick How do I send incomplete builds or should we avoid to send such builds to KCIDB?

@helen-fornazier
Copy link
Collaborator

fyi, there is an issue open to transform the valid status in builds to be a enum: kernelci/kcidb-io#82

Copy link
Collaborator

@spbnick spbnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spbnick spbnick merged commit 9cba1ee into kernelci:main Aug 8, 2024
5 of 6 checks passed
@JenySadadia JenySadadia deleted the remove-build-error branch August 8, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants