Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omap notification subscription #579

Merged
merged 3 commits into from
Sep 24, 2024
Merged

omap notification subscription #579

merged 3 commits into from
Sep 24, 2024

Conversation

JenySadadia
Copy link
Collaborator

Enable automated test report for omap tree.

Copy link
Collaborator

@spbnick spbnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple nitpicks. Thank you!

kcidb/monitor/output.py Outdated Show resolved Hide resolved
kcidb/monitor/subscriptions/linux_stable_rc.py Outdated Show resolved Hide resolved
kcidb/monitor/subscriptions/linux_omap.py Outdated Show resolved Hide resolved
@JenySadadia
Copy link
Collaborator Author

Looks like we need to merge #582 before merging this one.

spbnick
spbnick previously approved these changes Sep 23, 2024
Copy link
Collaborator

@spbnick spbnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, Jeny ❤️

Jeny Sadadia added 3 commits September 24, 2024 11:33
Add argument to provide context variables to `NotificationMessage`
class. Use the context variable to generate email notification
message in `Notification` class.

Signed-off-by: Jeny Sadadia <[email protected]>
Provide `stable-rc` repo URL as context variable
to `stable_rc_revision_description` template.
It will enable us to re-use the same template to
get revision description information for
a different tree such as `omap`.

Signed-off-by: Jeny Sadadia <[email protected]>
The report would contain build and boot failures.

Signed-off-by: Jeny Sadadia <[email protected]>
Copy link
Collaborator

@spbnick spbnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JenySadadia JenySadadia merged commit d939cb8 into main Sep 24, 2024
6 checks passed
@JenySadadia JenySadadia deleted the omap-subscription branch September 24, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants