-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
omap
notification subscription
#579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple nitpicks. Thank you!
f4da2af
to
dd1de38
Compare
Looks like we need to merge #582 before merging this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you, Jeny ❤️
Add argument to provide context variables to `NotificationMessage` class. Use the context variable to generate email notification message in `Notification` class. Signed-off-by: Jeny Sadadia <[email protected]>
Provide `stable-rc` repo URL as context variable to `stable_rc_revision_description` template. It will enable us to re-use the same template to get revision description information for a different tree such as `omap`. Signed-off-by: Jeny Sadadia <[email protected]>
The report would contain build and boot failures. Signed-off-by: Jeny Sadadia <[email protected]>
dd1de38
to
fc5e509
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Enable automated test report for
omap
tree.