omap notification subscription
#579
Open
+48
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 18, 2024 16:19
Add argument to provide context variables to `NotificationMessage` class. Use the context variable to generate email notification message in `Notification` class. Signed-off-by: Jeny Sadadia <[email protected]>
Provide `stable-rc` repo URL as context variable to `stable_rc_revision_description` template. It will enable us to re-use the same template to get revision description information for a different tree such as `omap`. Signed-off-by: Jeny Sadadia <[email protected]>
The report would contain build and boot failures. Signed-off-by: Jeny Sadadia <[email protected]>
spbnick
requested changes
Sep 23, 2024
| @@ -31,12 +31,13 @@ | |||
| LOGGER = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| class NotificationMessage: | |||
| class NotificationMessage: # pylint: disable=too-many-instance-attributes | |||
There was a problem hiding this comment.
Could you put this above the class declaration? It will be easier to spot then, and will match the existing convention.
| @@ -32,5 +32,6 @@ def match_revision(revision): | |||
| "Shreeya Patel <[email protected]>"], | |||
| body='{% include "stable_rc_revision_description.txt.j2" %}', | |||
| cc=["KernelCI Results Staging <[email protected]>"], | |||
| due=datetime.now(timezone.utc) + timedelta(hours=3) | |||
| due=datetime.now(timezone.utc) + timedelta(hours=3), | |||
| context={'repo_url': repo_url} | |||
There was a problem hiding this comment.
Could you name this main_repo_url, or something like that, so it's clearer there are other repos, and it's not the only one?
| "Helen Mae Koike Fornazier <[email protected]>"], | ||
| body='{% include "stable_rc_revision_description.txt.j2" %}', | ||
| due=datetime.now(timezone.utc) + timedelta(hours=3), | ||
| context={'repo_url': repo_url} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable automated test report for
omaptree.