Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Test Mode for Build #571

Merged

Conversation

axkar
Copy link
Collaborator

@axkar axkar commented Aug 21, 2024

To support testing, the 'test-config.cfg' has been introduced in Infix. Additionally, a test mode for the running image is required for this configuration to be applied.

Basically the 'test-config' will only be generated and loaded when the device is in 'test-mode', which is determined by the presence of the '/mnt/aux/test-mode file'. However, placing this file via the Qeneth system proved to be inconvenient in the test environment. Therefore, the entire image is built in test mode, with the 'test-mode' file preloaded onto the disk image (specifically in the auxiliary partition).

To support this, a new variable, '(bool) DISK_IMAGE_TEST_MODE', has been introduced:

  • 'enabled': the image will be built in the test mode;
  • 'disabled': the image will be built in the standard mode.

@troglobit
Copy link
Contributor

Please reference #568, e.g., "Part of issue #568", in the commit message so we can tie it all together, and always write a neat summary (details and novels in commit messages) also for the pull request itself.

Copy link
Contributor

@wkz wkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love how neat this came out. Great job! 👏 👏

board/common/mkdisk.sh Outdated Show resolved Hide resolved
board/common/Config.in Outdated Show resolved Hide resolved
board/common/mkdisk.sh Outdated Show resolved Hide resolved
@axkar
Copy link
Collaborator Author

axkar commented Aug 23, 2024

Please reference #568, e.g., "Part of issue #568", in the commit message so we can tie it all together, and always write a neat summary (details and novels in commit messages) also for the pull request itself.

Sure :) Thnx

@axkar axkar requested a review from wkz August 23, 2024 08:41
To support testing, the test-config.cfg file has been introduced in Infix.
Additionally, a "test mode" for the running image is required for this
configuration to be applied.

Basically the test-config will only be loaded when the device is in test mode,
which is determined by the presence of the /mnt/aux/test-mode file.
However, placing this file via the Qeneth system proved to be
inconvenient in the test environment. Therefore, it the entire image is
built in test mode, with the 'test-mode' file preloaded onto the disk
image (specifically in the auxiliary partition).
To support this, a new variable, (bool) DISK_IMAGE_TEST_MODE, has been
introduced:

 enabled: the image will be built in the test mode;
 disabled: the image will be built in the standard mode.

Part of issue kernelkit#568
@axkar axkar force-pushed the introduce-test-mode-for-build branch from 3927d29 to 9c15c5c Compare August 23, 2024 09:26
Copy link
Contributor

@wkz wkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

If you rebase this on kernelkit:main, I think the build issues should go away, so that we can verify that we don't have any breaking changes.

@mattiaswal mattiaswal merged commit a44f83c into kernelkit:main Aug 26, 2024
4 checks passed
@axkar axkar deleted the introduce-test-mode-for-build branch August 26, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants