improved the disposing of server

kerryjiang · Jan 26, 2025 · 2028d16 · 2028d16
1 parent e313305
commit 2028d16
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 2 deletions.
diff --git a/src/SuperSocket.Server.Abstractions/Connections/IConnectionListener.cs b/src/SuperSocket.Server.Abstractions/Connections/IConnectionListener.cs
@@ -9,7 +9,7 @@ namespace SuperSocket.Server.Abstractions.Connections
 {
     public delegate ValueTask NewConnectionAcceptHandler(ListenOptions listenOptions, IConnection connection);
 
-    public interface IConnectionListener
+    public interface IConnectionListener : IDisposable
     {
         ListenOptions Options { get; }
 

diff --git a/src/SuperSocket.Server/Connection/TcpConnectionListener.cs b/src/SuperSocket.Server/Connection/TcpConnectionListener.cs
@@ -131,7 +131,7 @@ public Task StopAsync()
             var listenSocket = _listenSocket;
 
             if (listenSocket == null)
-                return Task.Delay(0);
+                return Task.CompletedTask;
 
             _stopTaskCompletionSource = new TaskCompletionSource<bool>();
 
@@ -145,5 +145,15 @@ public override string ToString()
         {
             return Options?.ToString();
         }
+
+        public void Dispose()
+        {
+            var listenSocket = _listenSocket;
+
+            if (listenSocket != null && Interlocked.CompareExchange(ref _listenSocket, null, listenSocket) == listenSocket)
+            {
+                listenSocket.Dispose();
+            }
+        }
     }
 }
diff --git a/src/SuperSocket.Server/SuperSocketService.cs b/src/SuperSocket.Server/SuperSocketService.cs
@@ -555,6 +555,14 @@ protected virtual async ValueTask DisposeAsync(bool disposing)
                     {
                         _logger.LogError(e, "Failed to stop the server");
                     }
+
+                    if (_connectionListeners.Any())
+                    {
+                        foreach (var listener in _connectionListeners)
+                        {
+                            listener.Dispose();
+                        }
+                    }
                 }
 
                 disposedValue = true;

diff --git a/src/SuperSocket.Udp/UdpConnectionListener.cs b/src/SuperSocket.Udp/UdpConnectionListener.cs
@@ -224,5 +224,15 @@ public override string ToString()
         {
             return Options?.ToString();
         }
+
+        public void Dispose()
+        {
+            var listenSocket = _listenSocket;
+
+            if (listenSocket != null && Interlocked.CompareExchange(ref _listenSocket, null, listenSocket) == listenSocket)
+            {
+                listenSocket.Dispose();
+            }
+        } 
     }
 }