-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for inverters and VE.Bus devices #108
Open
j9brown
wants to merge
32
commits into
keshavdv:main
Choose a base branch
from
j9brown:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes Issue keshavdv#99 KeyError: (<VictronSensor.EXTERNAL_DEVICE_LOAD: 'external_device_load'>, <Units.ELECTRIC_CURRENT_AMPERE: 'A'>
Bump victron-ble to 0.8.0
fix repo download link in README
The integration failed to load due to changes in the type signature of PassiveBluetoothProcessor. Added Smart Lithium and Smart Protect devices. Fixed an issue with meter type and temperature reporting in DC Energy Meters.
Changed the device class of the 'off_reason' and 'alarm_reason' sensors to reflect that they encode multiple bits of information.
This PR will need some cleaning up before merging. I forked it from another fork downstream so there’s probably some redundancy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes depend on my fork of keshavdv/victron-ble#50
I bumped the version number and changed HACS metadata while developing these features. We will likely want to revert some of those metadata changes.
Fixed some bugs with handling unavailable states that were exposed after fixing victron-ble to correctly parse and report them.