chore(ui): legends are now working

kestra-io · Nov 29, 2024 · 889499c · 889499c
1 parent 2901726
commit 889499c
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 22 deletions.
diff --git a/ui/src/components/dashboard/components/charts/custom/Bar.vue b/ui/src/components/dashboard/components/charts/custom/Bar.vue
@@ -62,7 +62,6 @@
                         customBarLegend: {
                             containerID,
                             uppercase: true,
-                            length: generated.value.length,
                         },
                     }
                     : {}),

diff --git a/ui/src/components/dashboard/components/charts/custom/Pie.vue b/ui/src/components/dashboard/components/charts/custom/Pie.vue
@@ -62,7 +62,6 @@
                     ? {
                         totalsLegend: {
                             containerID,
-                            length: generated.value.length,
                         },
                     }
                     : {}),

diff --git a/ui/src/components/dashboard/components/charts/custom/TimeSeries.vue b/ui/src/components/dashboard/components/charts/custom/TimeSeries.vue
@@ -67,7 +67,6 @@
                         customBarLegend: {
                             containerID,
                             uppercase: true,
-                            length: generated.value.length,
                         },
                     }
                     : {}),

diff --git a/ui/src/components/dashboard/components/charts/legend.js b/ui/src/components/dashboard/components/charts/legend.js
@@ -4,7 +4,7 @@ import {getConsistentHEXColor} from "../../../../utils/charts.js";
 
 const getOrCreateLegendList = (chart, id, direction = "row") => {
     const legendContainer = document.getElementById(id);
-    let listContainer = legendContainer.querySelector("ul");
+    let listContainer = legendContainer?.querySelector("ul");
 
     if (!listContainer) {
         listContainer = document.createElement("ul");
@@ -14,17 +14,15 @@ const getOrCreateLegendList = (chart, id, direction = "row") => {
         listContainer.style.margin = 0;
         listContainer.style.padding = 0;
 
-        legendContainer.appendChild(listContainer);
+        legendContainer?.appendChild(listContainer);
     }
 
     return listContainer;
 };
 
 export const barLegend = {
     id: "barLegend",
-    afterUpdate(chart, args, options, length) {
-        if (!length) return;
-
+    afterUpdate(chart, args, options) {
         const ul = getOrCreateLegendList(chart, options.containerID);
 
         while (ul.firstChild) {
@@ -99,9 +97,7 @@ export const barLegend = {
 
 export const customBarLegend = {
     id: "customBarLegend",
-    afterUpdate(chart, args, options, length) {
-        if (!length) return;
-
+    afterUpdate(chart, args, options) {
         const ul = getOrCreateLegendList(chart, options.containerID);
 
         while (ul.firstChild) {
@@ -170,9 +166,7 @@ export const customBarLegend = {
 
 export const totalsLegend = {
     id: "totalsLegend",
-    afterUpdate(chart, args, options, length) {
-        if (!length) return;
-
+    afterUpdate(chart, args, options) {
         const ul = getOrCreateLegendList(chart, options.containerID, "column");
 
         while (ul.firstChild) {

diff --git a/ui/src/components/dashboard/components/tables/custom/Table.vue b/ui/src/components/dashboard/components/tables/custom/Table.vue
@@ -99,11 +99,3 @@
     );
     onMounted(() => generate());
 </script>
-
-<style lang="scss" scoped>
-$height: 200px;
-
-.chart {
-    max-height: $height;
-}
-</style>
-Original file line number
+Diff line change
@@ Expand Up / @@ -62,7 +62,6 @@ @@
                         ? {
                             totalsLegend: {
                                 containerID,
-                                length: generated.value.length,
                             },
                         }
                         : {}),
@@ Expand Down @@