fix: remove-some-js-warnings (#6195)

* remove some warnings * remove last warning on plugins * fix required alt
kestra-io · Nov 29, 2024 · a6804cc · a6804cc
1 parent 8293a0f
commit a6804cc
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 7 deletions.
diff --git a/ui/src/components/flows/FlowMetrics.vue b/ui/src/components/flows/FlowMetrics.vue
@@ -63,7 +63,7 @@
                 />
             </el-form-item>
             <el-form-item>
-                <refresh-button class="float-right" @refresh="load" :can-auto-refresh="canAutoRefresh" />
+                <refresh-button @refresh="load" :can-auto-refresh="canAutoRefresh" />
             </el-form-item>
         </collapse>
     </nav>

diff --git a/ui/src/components/layout/DottedLayout.vue b/ui/src/components/layout/DottedLayout.vue
@@ -17,10 +17,10 @@
 <script setup lang="ts">
     defineProps<{
         embed: boolean;
-        phrase:string;
-        alt: {type: string, required: false, default: undefined};
-        image:string;
-        imageDark:string;
+        phrase: string;
+        alt?: string;
+        image: string;
+        imageDark: string;
     }>();
 </script>
 

diff --git a/ui/src/components/plugins/PluginHome.vue b/ui/src/components/plugins/PluginHome.vue
@@ -65,7 +65,7 @@
                         </ul>
                     </div>
                 </template>
-                <div v-if="isVisible(plugin)" class="plugin-card" @click="openGroup(plugin)">
+                <div class="plugin-card" @click="openGroup(plugin)">
                     <task-icon
                         class="size"
                         :only-icon="true"
@@ -90,6 +90,10 @@
             plugins: {
                 type: Array,
                 required: true
+            },
+            embed: {
+                type: Boolean,
+                default: false
             }
         },
         components: {
@@ -144,7 +148,9 @@
                             plugin.triggers.some(trigger => trigger.toLowerCase().includes(this.searchInput.toLowerCase())) ||
                             plugin.conditions.some(condition => condition.toLowerCase().includes(this.searchInput.toLowerCase())) ||
                             plugin.taskRunners.some(taskRunner => taskRunner.toLowerCase().includes(this.searchInput.toLowerCase()))
-                    }).sort((a, b) => {
+                    })
+                    .filter(plugin => this.isVisible(plugin))
+                    .sort((a, b) => {
                         const nameA = a.manifest["X-Kestra-Title"].toLowerCase(),
                               nameB = b.manifest["X-Kestra-Title"].toLowerCase();