fix: Prevent resource leak by closing the PreparedStatement (#390)

Co-authored-by: BURJA Lucian <[email protected]>
kestra-io · Oct 8, 2024 · 504c457 · 504c457
1 parent 54aa50c
commit 504c457
Showing 1 changed file with 11 additions and 10 deletions.
diff --git a/plugin-jdbc/src/main/java/io/kestra/plugin/jdbc/AbstractJdbcBatch.java b/plugin-jdbc/src/main/java/io/kestra/plugin/jdbc/AbstractJdbcBatch.java
@@ -117,20 +117,21 @@ public Output run(RunContext runContext) throws Exception {
                 })
                 .buffer(this.chunk, this.chunk)
                 .map(throwFunction(o -> {
-                    PreparedStatement ps = connection.prepareStatement(sql);
-                    ParameterType parameterMetaData = ParameterType.of(ps.getParameterMetaData());
+                    try (PreparedStatement ps = connection.prepareStatement(sql)) {
+                        ParameterType parameterMetaData = ParameterType.of(ps.getParameterMetaData());
 
-                    for (Object value : o) {
-                        ps = this.addRows(ps, parameterMetaData, value, cellConverter, connection);
+                        for (Object value : o) {
+                            this.addRows(ps, parameterMetaData, value, cellConverter, connection);
 
-                        ps.addBatch();
-                        ps.clearParameters();
-                    }
+                            ps.addBatch();
+                            ps.clearParameters();
+                        }
 
-                    int[] updatedRows = ps.executeBatch();
-                    connection.commit();
+                        int[] updatedRows = ps.executeBatch();
+                        connection.commit();
 
-                    return Arrays.stream(updatedRows).sum();
+                        return Arrays.stream(updatedRows).sum();
+                    }
                 }));
 
             Integer updated = flowable