Skip to content

Commit

Permalink
refactor: migrate to Java ServiceLoader for plugin registration
Browse files Browse the repository at this point in the history
  • Loading branch information
fhussonnois committed Apr 24, 2024
1 parent bc9a746 commit 6b4367f
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 17
java-version: 21

- name: Validate Gradle wrapper
uses: gradle/wrapper-validation-action@v2
Expand Down
20 changes: 9 additions & 11 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ repositories {
}
}

sourceCompatibility = 17
targetCompatibility = 17
sourceCompatibility = 21
targetCompatibility = 21

group "io.kestra.plugin"
description 'Utilize Apache Spark for data processing within Kestra pipelines.'
Expand All @@ -33,23 +33,20 @@ tasks.withType(JavaCompile) {
}

dependencies {
// lombok
// Lombok
annotationProcessor "org.projectlombok:lombok:$lombokVersion"
compileOnly "org.projectlombok:lombok:$lombokVersion"

// micronaut
annotationProcessor platform("io.micronaut.platform:micronaut-platform:$micronautVersion")
annotationProcessor "io.micronaut:micronaut-inject-java"
annotationProcessor "io.micronaut.validation:micronaut-validation-processor"

// Micronaut
compileOnly platform("io.micronaut.platform:micronaut-platform:$micronautVersion")
compileOnly "io.micronaut:micronaut-inject"
compileOnly "io.micronaut.validation:micronaut-validation"
compileOnly "io.micronaut.reactor:micronaut-reactor"

// kestra
// Kestra
compileOnly group: "io.kestra", name: "core", version: kestraVersion

// Lib
annotationProcessor group: "io.kestra", name: "processor", version: kestraVersion

// Spark lib: must be aligned with the docker-compose-ci.yaml files and the image used in test
api group: 'org.apache.spark', name: 'spark-launcher_2.13', version: '3.5.1'
implementation group: "io.kestra.plugin", name: "plugin-script", version: kestraVersion
Expand Down Expand Up @@ -86,6 +83,7 @@ dependencies {
testImplementation "io.micronaut.test:micronaut-test-junit5"

// kestra
testAnnotationProcessor group: "io.kestra", name: "processor", version: kestraVersion
testImplementation group: "io.kestra", name: "core", version: kestraVersion
testImplementation group: "io.kestra", name: "storage-local", version: kestraVersion
testImplementation group: "io.kestra", name: "runner-memory", version: kestraVersion
Expand Down
4 changes: 2 additions & 2 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version=0.17.0-SNAPSHOT
kestraVersion=[0.16,)
kestraVersion=[0.17,)
micronautVersion=4.3.7
lombokVersion=1.18.32
lombokVersion=1.18.32

0 comments on commit 6b4367f

Please sign in to comment.