Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] KevaQL #51

Draft
wants to merge 13 commits into
base: develop
Choose a base branch
from
Draft

[WIP] KevaQL #51

wants to merge 13 commits into from

Conversation

tuhuynh27
Copy link
Member

@tuhuynh27 tuhuynh27 commented Nov 20, 2021

Naive KQL

image

KQL supports:

  • CREATE TABLE
  • DROP TABLE
  • INSERT
  • UPDATE
  • DELETE
  • SELECT
  • AND, OR
  • EQUAL, NOT EQUAL
  • MIN, MAX
  • COUNT, AVG, SUM
  • NULL VALUES
  • GROUP BY
  • OFFSET
  • LIMIT

@tuhuynh27 tuhuynh27 added the enhancement New feature or request label Nov 20, 2021
@tuhuynh27 tuhuynh27 self-assigned this Nov 20, 2021
import java.util.stream.Stream;

public class KqlManager {
private final Map<String, List<KevaColumnDefinition>> tableMetadata = new ConcurrentHashMap<>();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Are we going to process queries in single thread manner? If yes then we can change Map implementation to improve performance.
Ex: HashMap offer a better performance than ConcurrentHashMap in single thread
https://stackoverflow.com/questions/1378310/performance-concurrenthashmap-vs-hashmap

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haphananhtuan Thanks for pointing out the issue, I've just changed to use kevaDatabase, it will be persisted along with kdb.dump

Copy link
Member

@axblueblader axblueblader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, also update docs on design decision when got time

@tuhuynh27
Copy link
Member Author

Still cannot be merged now, the visitor class is cursed

image

@tuhuynh27 tuhuynh27 force-pushed the develop branch 2 times, most recently from 1a702d1 to dcff9ea Compare June 2, 2022 09:16
@tuhuynh27 tuhuynh27 force-pushed the develop branch 2 times, most recently from 5ca77a9 to b1c70d3 Compare October 20, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants