-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] KevaQL #51
base: develop
Are you sure you want to change the base?
[WIP] KevaQL #51
Conversation
import java.util.stream.Stream; | ||
|
||
public class KqlManager { | ||
private final Map<String, List<KevaColumnDefinition>> tableMetadata = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Are we going to process queries in single thread manner? If yes then we can change Map implementation to improve performance.
Ex: HashMap
offer a better performance than ConcurrentHashMap
in single thread
https://stackoverflow.com/questions/1378310/performance-concurrenthashmap-vs-hashmap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haphananhtuan Thanks for pointing out the issue, I've just changed to use kevaDatabase
, it will be persisted along with kdb.dump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, also update docs on design decision when got time
bb8e9d9
to
89d6dd9
Compare
fff21d9
to
87dc634
Compare
1a702d1
to
dcff9ea
Compare
5ca77a9
to
b1c70d3
Compare
Naive KQL
KQL supports: