Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vidartf fix prefdir - validation async snafu #14

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Vidartf fix prefdir - validation async snafu #14

wants to merge 20 commits into from

Commits on Nov 3, 2022

  1. Make preferred_dir content manager trait 

    Move the preferred_dir trait to content manager, but keep the old one for backwards compatibility. The new location should also cause the value to be read later in the init, allowing us to avoid the deferred validation. Also fixes an issue with escaping the root dir on Windows if an absolute path is passed.
    @vidartf
    vidartf committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    0f26c57 View commit details
    Browse the repository at this point in the history

  2. Tweak linux test

    @vidartf
    vidartf committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    1b9bf6e View commit details
    Browse the repository at this point in the history

  3. Fix gateway test that used absolute paths

    @vidartf
    vidartf committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    639f460 View commit details
    Browse the repository at this point in the history

  4. Tweak preferred dir exception text

    @vidartf
    vidartf committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    c33c7d3 View commit details
    Browse the repository at this point in the history

  5. Some fixes to preferred_dir default handling

    @vidartf
    vidartf committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    746eef8 View commit details
    Browse the repository at this point in the history

  6. Fix test on Linux

    @vidartf
    vidartf committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    3ed74ab View commit details
    Browse the repository at this point in the history

  7. Unused import

    @vidartf
    vidartf committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    f70ac33 View commit details
    Browse the repository at this point in the history

  8. Some fixes to preferred_dir default handling

    @vidartf
    vidartf committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    41e744c View commit details
    Browse the repository at this point in the history

  9. Update jupyter_server/services/contents/filemanager.py 

    Co-authored-by: Kevin Bates <[email protected]>
    @vidartf @kevin-bates
    vidartf and kevin-bates committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    dda39a8 View commit details
    Browse the repository at this point in the history

  10. Move HTTPError remap up the stack

    @vidartf
    vidartf committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    3b28b70 View commit details
    Browse the repository at this point in the history

  11. Update minimal client version

    @vidartf
    vidartf committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    826e9cf View commit details
    Browse the repository at this point in the history

  12. fix terminal test on Windows

    @vidartf
    vidartf committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    4a3b14c View commit details
    Browse the repository at this point in the history

  13. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @vidartf
    pre-commit-ci[bot] authored and vidartf committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    db4ae3a View commit details
    Browse the repository at this point in the history

  14. Fix preferred-dir tests

    @kevin-bates @vidartf
    kevin-bates authored and vidartf committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    340b21a View commit details
    Browse the repository at this point in the history

  15. Remove unused import - flake8 issue

    @kevin-bates
    kevin-bates committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    eef0036 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'main' into fix-prefdir

    @kevin-bates
    kevin-bates authored Nov 3, 2022
    Configuration menu
    Copy the full SHA
    05467e5 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Merge branch 'main' into fix-prefdir

    @vidartf
    vidartf authored Nov 8, 2022
    Configuration menu
    Copy the full SHA
    93d6f1a View commit details
    Browse the repository at this point in the history

  2. Don't validate preferred_dir trait

    @vidartf
    vidartf committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    9b04bb4 View commit details
    Browse the repository at this point in the history

  3. Some more output in test

    @vidartf
    vidartf committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    85eba17 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Validate preferred_dir relative to root_dir location, update tests

    @kevin-bates
    kevin-bates committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    f803c17 View commit details
    Browse the repository at this point in the history