Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB Pointcloud and Live Camera Tracking on Pointcloud Viewer #12

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

omarabid59
Copy link

I've added the changes from alexanderkoumis repository for RGB pointcloud visualization.

Also, I've added a nifty feature to toggle Live Camera Tracking on the pointcloud viewer using either dynamic reconfigure or by hitting the m key. For a visualization of this, please see this Wiki.

Finally, I've added the ability to output the rendered pointcloud display as a topic. This is set to disabled by default. To enable, see `lsd_slam_viewer/src/settings.cpp or using dynamic reconfigure.

@alexanderkoumis
Copy link

Thank you for this work. I am noticing in the pointcloud publisher you are publishing the raw depth values and not factoring in camera extrinsics (cam_to_world)? Are you accounting for this somewhere else?

@alexanderkoumis
Copy link

Can you post a quick screencapture of the pointcloud being published in Rviz?

@alexanderkoumis
Copy link

Nice to see this is still being worked on years after it was abandoned by original developers

@omarabid59
Copy link
Author

The pointcloud publisher only outputs the raw values, so there's no camera extrinsic required here. See below for a screenshot of the topic being published in Rviz.

rviz_output

@alexanderkoumis
Copy link

Oh okay, got it. I thought this was a pointcloud publisher something akin to https://github.com/alexanderkoumis/lsd_slam_to_pcl, didn't read the commit close enough. Anyways, thank you for your work, like I said I am really glad this project is still alive, one of the best open source RGB -> depth packages out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants