Skip to content

Commit

Permalink
setup.py: Block urllib3 >=2 for PyPy (including 3.10)
Browse files Browse the repository at this point in the history
It kept failing CI
  • Loading branch information
hartwork committed Dec 8, 2023
1 parent c062c9f commit 0e57182
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,15 @@ def run_tests(self):
"PyYAML",
"wrapt",
"yarl",
# Support for urllib3 >=2 needs Python >=3.10
# so we need to block urllib3 >=2 for Python <3.10 for now.
# Support for urllib3 >=2 needs CPython >=3.10
# so we need to block urllib3 >=2 for Python <3.10 and PyPy for now.
# Note that vcrpy would work fine without any urllib3 around,
# so this block and the dependency can be dropped at some point
# in the future. For more Details:
# https://github.com/kevin1024/vcrpy/pull/699#issuecomment-1551439663
"urllib3 <2; python_version <'3.10'",
# https://github.com/kevin1024/vcrpy/pull/775#issuecomment-1847849962
"urllib3 <2; platform_python_implementation =='PyPy'",
]

tests_require = [
Expand Down

0 comments on commit 0e57182

Please sign in to comment.