Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save CI resources + document why each version is covered #792

Closed
wants to merge 1 commit into from

Conversation

hartwork
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (796dc8d) 90.10% compared to head (b452ea8) 90.10%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #792   +/-   ##
=======================================
  Coverage   90.10%   90.10%           
=======================================
  Files          27       27           
  Lines        1809     1809           
  Branches      335      335           
=======================================
  Hits         1630     1630           
  Misses        134      134           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hartwork
Copy link
Collaborator Author

hartwork commented Dec 11, 2023

@jairhenrique do you have any concerns regarding saving upon CPython 3.11 in the CI? Do you have a minute to review?

@jairhenrique
Copy link
Collaborator

@hartwork for me it doesn't make sense to remove python 3.11 from the testing matrix. I believe we should run the tests on all supported python versions as a minimum guarantee.

@hartwork
Copy link
Collaborator Author

@jairhenrique okay, I'll close then.

@hartwork hartwork closed this Dec 11, 2023
@jairhenrique jairhenrique deleted the save-ci-resources branch December 28, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants