Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly handle asyncio.run when loop exists #886

Merged
merged 1 commit into from
Dec 30, 2024
Merged

fix: correctly handle asyncio.run when loop exists #886

merged 1 commit into from
Dec 30, 2024

Conversation

alekseik1
Copy link
Contributor

@alekseik1 alekseik1 commented Dec 18, 2024 •
edited
Loading

This PR is a duplicate of #833 but:

  • no new event loop is set, which this could break other libraries
  • no thread pool is used - some folks might want have "how many threads did I create" checks in their tests

I tested this fix in my project with Starlette's TestClient - everything is working.

@jairhenrique
Copy link
Collaborator

@alekseik1 please rebase your branch with master.

@alekseik1
Copy link
Contributor Author

@jairhenrique done

@alekseik1
Copy link
Contributor Author

@jairhenrique could you please help with merging this PR? I'd really appreciate if a new release with this fix comes after New Year holidays!

@alekseik1
Copy link
Contributor Author

oh, forgot to mention issue this PR addresses, here it is: #628

@jairhenrique jairhenrique merged commit 3fb62e0 into kevin1024:master Dec 30, 2024
13 checks passed
@jairhenrique jairhenrique mentioned this pull request Jan 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jairhenrique jairhenrique jairhenrique approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alekseik1 @jairhenrique