Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (make file) : add conditional execution of build command and men… #154

Merged
merged 1 commit into from
Jan 26, 2025
Merged

feat (make file) : add conditional execution of build command and men… #154

merged 1 commit into from
Jan 26, 2025

Conversation

mitesh4000
Copy link
Contributor

makefile

  1. uname -m returns x86_64 in linux machine which is not valid value for GOARCH variable
  2. build_bin : it tries to execute every command so i added conditional execution

@mitesh4000
feat (make file) : add conditional execution of build command and men…
19afe0e 
…epulation for shell command output for linux machine
kevinanielsen
kevinanielsen approved these changes Jan 26, 2025
View reviewed changes
Copy link
Owner

@kevinanielsen kevinanielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for the contribution.

@kevinanielsen kevinanielsen merged commit efd5730 into kevinanielsen:main Jan 26, 2025
2 checks passed
@kevinanielsen kevinanielsen mentioned this pull request Jan 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinanielsen kevinanielsen kevinanielsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitesh4000 @kevinanielsen