-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies, migration from Snowpack to Vite, some minor fixes #429
Conversation
@kevinclement @seirl Who should be notified to review this? :) |
Thanks, this is awesome. It would be better if @kevinclement reviewed and merged this, I didn't work on this setup at all and I don't really know what I'm looking at. Maybe changing the build system will affect the CD and I have no control over this. |
Sounds reasonable, does @kevinclement check this repository every now and again? |
sorry for delay here. this looks good, thanks for updating to latest. |
doh! when this deployed in production it was busted. I'm looking into it, but have to shake off cobwebs since I haven't done this stuff in a while. It looks like the new svelte doesn't produce an index.html in the build directory like the old one, which is probably why it's busted. |
ok, think I fixed it now :) |
No problems at all, thanks for taking the time 👍😄 Shameless plug; I noticed among friends and guildies that SimpleArmory is the go-to tool nowadays for comparing the amount of mounts someone has, that's why I think it would be nice to expose the logic applied in SimpleArmory in an API. (i opened #428 to discuss this) |
thanks for the kind words @maxdekrieger. I'm glad the tool is providing value. The fact that it's been a goto has little to do with me recently and everything to do with @seirl and other contributors commitment to keeping the json up to date and curated. It's a labor of love for them for sure. I'll go look at other open item and comment there. |
Updated dependencies (fixes #358):
3.23
to3.47
1.0.0-next.34
to1.0.0-next.314
)1.0.0-next.2
to1.0.0-next.29
The CLI no longer has
svelte-kit adapt
, the adapt step now always happens when asvelte-kit build
is executed.As a bonus, the bumped dependencies make it possible to develop this application on Windows without using a virtual environment.
Minor changes:
Let me know what you think :)