Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, migration from Snowpack to Vite, some minor fixes #429

Merged
merged 5 commits into from
May 3, 2022

Conversation

maxdekrieger
Copy link
Contributor

@maxdekrieger maxdekrieger commented Apr 18, 2022

Updated dependencies (fixes #358):

  • Updated Svelte from 3.23 to 3.47
  • Updated Svelte-kit accordingly (1.0.0-next.34 to 1.0.0-next.314)
  • Updated Svelte static adapter from 1.0.0-next.2 to 1.0.0-next.29
  • Removed Snowpack, as Svelte-kit now uses Vite under the hood. Transfered the relevant configuration from Snowpack config to Vite config (embedded in Svelte config)

The CLI no longer has svelte-kit adapt, the adapt step now always happens when a svelte-kit build is executed.

As a bonus, the bumped dependencies make it possible to develop this application on Windows without using a virtual environment.

Minor changes:

Let me know what you think :)

@maxdekrieger maxdekrieger changed the title Migration from Snowpack to Vite Update dependencies, migration from Snowpack to Vite Apr 18, 2022
@maxdekrieger maxdekrieger changed the title Update dependencies, migration from Snowpack to Vite Update dependencies, migration from Snowpack to Vite, some minor fixes Apr 18, 2022
@maxdekrieger maxdekrieger marked this pull request as ready for review April 18, 2022 18:35
@maxdekrieger
Copy link
Contributor Author

@kevinclement @seirl Who should be notified to review this? :)

@seirl
Copy link
Collaborator

seirl commented Apr 22, 2022

Thanks, this is awesome. It would be better if @kevinclement reviewed and merged this, I didn't work on this setup at all and I don't really know what I'm looking at. Maybe changing the build system will affect the CD and I have no control over this.

@maxdekrieger
Copy link
Contributor Author

Sounds reasonable, does @kevinclement check this repository every now and again?

@kevinclement
Copy link
Owner

sorry for delay here. this looks good, thanks for updating to latest.

@kevinclement kevinclement merged commit 826434c into kevinclement:master May 3, 2022
@kevinclement
Copy link
Owner

doh! when this deployed in production it was busted. I'm looking into it, but have to shake off cobwebs since I haven't done this stuff in a while. It looks like the new svelte doesn't produce an index.html in the build directory like the old one, which is probably why it's busted.

@kevinclement
Copy link
Owner

ok, think I fixed it now :)

@maxdekrieger
Copy link
Contributor Author

No problems at all, thanks for taking the time 👍😄

Shameless plug; I noticed among friends and guildies that SimpleArmory is the go-to tool nowadays for comparing the amount of mounts someone has, that's why I think it would be nice to expose the logic applied in SimpleArmory in an API. (i opened #428 to discuss this)

@kevinclement
Copy link
Owner

thanks for the kind words @maxdekrieger. I'm glad the tool is providing value. The fact that it's been a goto has little to do with me recently and everything to do with @seirl and other contributors commitment to keeping the json up to date and curated. It's a labor of love for them for sure. I'll go look at other open item and comment there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reputation view bug, one minor overlap Migration from Snowpack to Vite?
3 participants