Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Dragonflight data import #469

Merged
merged 6 commits into from
Dec 1, 2022
Merged

[WIP] Dragonflight data import #469

merged 6 commits into from
Dec 1, 2022

Conversation

seirl
Copy link
Collaborator

@seirl seirl commented Nov 6, 2022

Just keeping this as a draft because I started working on the mounts. There's so little information right now in the wowhead comments that it's really too soon to attempt a categorization.

@brikr
Copy link

brikr commented Nov 23, 2022

Hey there!
Would it be reasonable to put all of the mounts into an "Uncategorized" or "Unknown" category so that we can have some UI that shows them? And as we learn where they are from they could be updated.

The way it is now, there are mounts that folks have already collected (e.g. 500 mount achievement or the Dracthyr race mounts) that don't show in the list. The counts are also a little funny because of this

@seirl
Copy link
Collaborator Author

seirl commented Nov 23, 2022

Yes, that's usually what I do for the mounts that I can't find. I just paused this because there were just so many of them that were unknown. I will try to have something up before the expansion launch.

@seirl
Copy link
Collaborator Author

seirl commented Nov 24, 2022

See #474 which discusses the current issue that stops me from doing the data import for Dragonflight.

@seirl seirl marked this pull request as ready for review December 1, 2022 11:45
@seirl seirl merged commit 19e9a1e into master Dec 1, 2022
@seirl
Copy link
Collaborator Author

seirl commented Dec 1, 2022

Merging the mounts for now, we'll open other PRs for the other collectibles.

@seirl seirl deleted the dragonflight branch December 1, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants