-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dragonflight factions #493
Add Dragonflight factions #493
Conversation
d748d31
to
2c2fb3d
Compare
Update: fixed my local branch so it's not conflicting anymore (hopefully) |
Thanks for doing this. Btw we can automatically get the max renown level by checking the covenant rewards table. |
Is it possible the maruuk centaur and valdrakken accord weren't added by default because they have sub-reputations? That's my guess according to some debugging and figuring out the reputations fixer. I've added them manually for now. |
Yes, that's very likely. I have only been adding tree leaves for now because intermediate reps were weird. But we could fix that. Can you file a bug? |
Done: #495 |
fcfae2d
to
f4d3886
Compare
Updated the reputations fixer to import the maximum renown from the correct DBC files and rebased the branch. It's ready for review now :) |
This one is not as easy as I'd hoped.
TODO Back-end:
maxRenown
.TODO Front-end:
Development Notes:
Puzzling with the CSV build files gave me the following information
flag
set to2