Added setting to show hidden items #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved function so that it's not ran every single item, was applied correctly to other collectibles, forgot it here.
|
Was at baseball tournament all day but had a look now that I'm back. Left comment for bug I found that we should prob fix before we merge. |
|
Fixed using your suggestion, tested it & seems to work smoothly now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied corrections based on #610 and added a setting that lets you show any unobtainable items, it currently affects mounts, pets, toys and titles. (can be toggled from setting menu). The setting is off by default.
I also added a new attribute 'notReleased' for items that are in the game but were never released. These will not be shown with the above setting enabled.
I also corrected a bunch of titles that didn't have their corresponding achievement icon linked, I plan to fix a whole bunch more of the question mark icons next. I would also like to make this toggle affect FoS as well as legacy achievements, so will work on that as well.