Fix tooltip for Calescent Shalewing #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good 👍 @kevinclement is there any way we could prevent itemid's like these from being re-added every time the dataimporter is ran? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, thanks for the excellent tool. I resubbed late last year and I've been very happy using SA as a checklist for all the stuff I want to catch up on collecting.
I discovered this week that the tooltip for Calescent Shalewing wasn't working, a known previous issue originally mentioned in #610. It looks like this was fixed shortly after (didn't see exactly where) and then broke again at some point. Sandy Shalewing was re-fixed in #622 but it looks like Calescent was overlooked at that time; this PR resolves that.
This commit resolves the issue for me locally both with
npm run devand after building and previewing the build, but if I've overlooked anything that needs to be fixed, please let me know. I copied the solution from #622 pretty naively without actually digging into any of the actual logic of the app.Thanks again!