Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n #86

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

I18n #86

wants to merge 5 commits into from

Conversation

unconditional
Copy link
Contributor

This adds a basic i18n/l10n support. The main goal was to make achi URLs localized, i.e. a user selects the XX language and all WowHead URLs turn from http://wowhead.com/... into http://XX.wowhead.com/... which also makes the achi popups localized.
But that would be somewhat weird to let user choose language and only update URLs, thus the UI translation was made possible as well (header.html as an example).

@kevinclement
Copy link
Owner

This is a really good first start. This has been requested in the past, just haven't had cycles to go an implement it, so thanks for giving it a shot.

Couple of comments:

  1. I'm not sure I like the language selection as part of the header menu. I'd prefer it either be a drop down off the user/picture, or a submenu in help. Submenu in help would be easier I think. Though a drop down off the character/user would provide us more plugin points for future features.
  2. Seems like it only includes translations for the header menus and not translations in the pages themselves. Is this expected? I see wowhead links work, but the pages themselves and categories are still in english.

-kevin

@unconditional
Copy link
Contributor Author

Hey, thanks for the feedback.

  1. Do you have any vision of what that language dropdown might look like attached to the profile picture/name given that the profile name itself is a link to the battlenet profile page?
  2. Yes I just translated the header as an example to make sure it works. I'll push other content translation later.

@kevinclement
Copy link
Owner

I imagine it will probably turn into a drop down with a few options. I think I'm going to have to play with it a bit and check-in the change to allow for it, then we can build this on top of it.

@rakshazi
Copy link
Contributor

rakshazi commented Feb 25, 2019

Hello!
Came here for that PR :)
Any updates on it?
I think basic preset like XX.wowhead.com is really good starting point and SimpleArmory really needs it.
Example from my guild (RU server, a lot of guild mates speak only Russian): wow armory laggy as a shit and very unfriendly, but we cant give a link to perfect SimpleArmory, because of the used language.

PS: If you need help with translation to Russian, I can help

@seirl
Copy link
Collaborator

seirl commented Mar 7, 2019

Hi!

This PR would need to be rebased to be able to be reviewed.

After looking into it, I think it would be a better approach to use the i18n features of Angular directly: https://angular.io/guide/i18n

This would certainly be easier for new translations.

@seirl
Copy link
Collaborator

seirl commented Mar 7, 2019

I'm going to look into it, I don't think it should be that hard to use the Angular i18n and this pull-request as a basis for translation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants