Fix: improve scrolling speed and hiccups #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids multiple JS object loading and initializations
There are no navigation links which would trigger this.
`ChatView` works with a full chat. `MessageView` works on a single `Message`.
A single, unique, invisible view serves as scroll target for the "bottom" of the list.
`chat` is not changing anymore
|
Awesome work! 👀 |
Use again `.task()` modifier for loading, so we could (potentially in the future) load on a background queue (currently it uses the `mainContext`)
|
Thanks! I will review this after work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another draft PR which I'm working on: since code-highlighting takes ups real processing time, I thing it should be cached somehow.
The problem occurs when switching between chats.