Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(function): Fix Presto URL functions to more closely match Presto…
… Java's behavior (facebookincubator#11488) Summary: Today the Presto URL functions rely on a regex to extract features of a URL. Due to the limitations of regexes this is not sufficient to validate that a URL is indeed valid. This leads to a number of cases where Presto Java will return NULL due to an invalid URL and Velox will return some substring. To address this I've implemented a parser for URIs based on the RFC 3986 spec which can both validate a URL and extract features of it. While testing this change I noticed a number of other discrepancies between Presto Java's and Velox's implementations of these UDFs (mostly related to unescaping/decoding URLs or portions thereof) that had been missed, likely due to the noise from the different handling of invalid URLs. Those are addressed in this diff as well so that I could effectively test it. Reviewed By: kgpai Differential Revision: D65695961
- Loading branch information