Add support for HTTPS #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevmoo when you get a chance, would you be able to approve running the workflows for this PR please. |
|
@maks - still some tests to fix! |
kevmoo
reviewed
Apr 3, 2024
kevmoo
reviewed
Apr 3, 2024
kevmoo
reviewed
Apr 3, 2024
and having the sec context in the class might be useful for future use
|
@kevmoo I've pushed up a couple of commits that hopefully address the test failure and your feedback (thanks for looking at it so quickly!), when you get a chance could you kickoff the CI again (sigh not sure why Github is making you approve each run after you approved the first one on this PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds HTTPS support to dhttpd.
Thanks to the original author of PR #32 that this is based on.
Fixes: #1