windows analyzer tweaks for test capabilities #2043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbargnesi
changed the title
Make one initial pass on the run method and break it up into preamble and a loop to facilitate testing.
- pull get_pipe_path; it's dead code - add a bytes type hint for protected path functions; str's are broke - add some initial coverage
nbargnesi
force-pushed
the
win-analyzer-enshrinkening
branch
from
0e2873f to
135ecd9
Compare
nbargnesi
force-pushed
the
win-analyzer-enshrinkening
branch
from
8f76497 to
9246c4d
Compare
This makes it so that if a bytes-path is being protected, the str equivalent is also protected, and vice versa.
nbargnesi
force-pushed
the
win-analyzer-enshrinkening
branch
from
029e30e to
fc0c305
Compare
While we're here, LBYL inside Process __del__, h_process/h_thread may not be bound if callers use bad kwargs. And extend Process tests a bit.
It might make more sense to hoist the call to Analyzer() before the try/except, but any chance to catch failure conditions is better while this code is still in rough shape.
|
closing, will reopen with a fresh PR |
|
opened in #2056 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds analyzer test cases and will include some changes to the analyzer code to make testing easier.