fix/rework private package configuration #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some packages provide their own __init__. Rather than having to pass the package name to itself, rework private package configuration to derive the importable package from the package class module name. So for example if the "pdf" package is used, self.__class__.__module__ is: modules.packages.pdf And the data module derived from it becomes: data.packages.pdf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some analyzer packages provide their own
__init__. Rather than having to pass the package name to itself, rework private package configuration to derive the importable package from the package class module name.So for example if the "pdf" package is used,
self.__class__.__module__is:And the data module derived from it becomes: