Add integration time for ECalBarrelEta for CLD_o4_v05 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So far the steering file is not supporting any of the special flavour CLD options anyway. Is there a point to merge this before #17? |
andresailer
reviewed
Jun 24, 2024
andresailer
reviewed
Jun 24, 2024
This (release notes) must also contain the algorithm the change was applied to |
Co-authored-by: Andre Sailer <[email protected]>
Co-authored-by: Andre Sailer <[email protected]>
jmcarcell
force-pushed
the
integration-times
branch
from
34f3376
to
21520bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appears here: https://github.com/key4hep/k4geo/blob/main/FCCee/CLD/compact/CLD_o4_v05/LAr_ECalBarrel.xml#L84, and the Overlay algorithm complains even when not overlaying anything.
BEGINRELEASENOTES
ENDRELEASENOTES