Skip to content

Commit

Permalink
Make sure that files with the complete datamodel can be read (#361)
Browse files Browse the repository at this point in the history
* Move coll creation into type specific functions

- Easier for testing if the counter is reset for every type
- Easier to read / maintain

* Make creation functions importable

* Capitalize global variables

* Fix missing arguments and returns

* Import argparse and sys only when necessary

* Make sure to write all vector members of tracks

* Add check for complete EDM4hep file

* Run tests also for RNTuple files

* Also check Link collections

* Workaround pythonizations changing mutability of objects

* Rename tests to make it easier to define dependencies

* Move tests to more appropriate place

* Make sure to only run pytest on things it can run on

* Move imports to the top

* Check Link collections in the same order as in yaml file

* Don't start the counter at 0 to avoid hitting empty defaults

* Apply suggestions from code review

Co-authored-by: Mateusz Jakub Fila <[email protected]>

* Ignore regex matches from Dart printouts

---------

Co-authored-by: Mateusz Jakub Fila <[email protected]>
  • Loading branch information
tmadlener and m-fila authored Sep 16, 2024
1 parent 84c5268 commit 8e0c1b0
Show file tree
Hide file tree
Showing 5 changed files with 804 additions and 137 deletions.
Loading

0 comments on commit 8e0c1b0

Please sign in to comment.