-
Notifications
You must be signed in to change notification settings - Fork 35
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix the HepPDT related cmake warning and make sure that all tests bui…
…ld (#367) * Make sure that FindHepPDT module is available * Remove unnecessary FindHepMC module * Ensure HepMC 3.3 and make test build again with it
- Loading branch information
Showing
4 changed files
with
20 additions
and
52 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -104,7 +104,7 @@ IF(TARGET ROOT::ROOTDataFrame) | |
endif() | ||
|
||
|
||
find_package(HepMC3) | ||
find_package(HepMC3 3.3) | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
tmadlener
Author
Contributor
|
||
find_package(HepPDT) | ||
|
||
if(HepMC3_FOUND AND HepPDT_FOUND ) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry for the late check but this 3.3 should not be necessary, passing shared_ptr to
add_particle_in
oradd_particle_out
has been there since 3.0.0. Did you check this or was the 3.3 coming from the current version? I get locally some warnings so for me it's worth it to remove it.