-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use FILE_SET
to install the headers in /include
together with the edm4hep library
#235
Conversation
BUILD_INTERFACE
and INSTALL_INTERFACE
for edm4hepFILE_SET
to install the headers in /include
together with the edm4hep library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How important is this for the new Key4hep release?
It seems the only thing that is missing are a few format complaints from pre-commit / clang-format. Which either haven't been caught by previous versions of clang-format, or the file wasn't checked. Anyhow, this should be fairly straight forward to fix.
For the release it doesn't matter. About the complaints, we can ignore them since I get different ones with the new |
Right now the pre-commit CI works fine but there are changes, probably due to a change in the version of |
BEGINRELEASENOTES
FILE_SET
to install the headers in the top folder together with the library. This also adds them in theBUILD_INTERFACE
, something that a simpleINSTALL
doesn't do.ENDRELEASENOTES
FILE_SET
requires CMake 2.23 so the version of the LCG stacks has to be bumped. I discovered that it also has the nice property that it complains if any of the sources that are attached to the library are not installed.