Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PROJECT_BINARY_DIR instead of CMAKE_BINARY_DIR to always locate the test files #368

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Use PROJECT_BINARY_DIR instead of CMAKE_BINARY_DIR to always locate the test files #368

merged 1 commit into from
Sep 16, 2024

Conversation

jmcarcell
Copy link
Contributor

Introduced in #361, CMAKE_BINARY_DIR won't work if EDM4hep is built from another project.

BEGINRELEASENOTES

  • Use PROJECT_BINARY_DIR instead of CMAKE_BINARY_DIR to always locate the test files

ENDRELEASENOTES

@tmadlener tmadlener enabled auto-merge (squash) September 16, 2024 15:33
@tmadlener tmadlener enabled auto-merge (squash) September 16, 2024 15:50
@tmadlener tmadlener merged commit 189f162 into main Sep 16, 2024
12 of 15 checks passed
@tmadlener tmadlener deleted the project-binary-dir branch September 16, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcarcell @tmadlener