Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename GeoSvc to ActsGeoSvc #12

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Rename GeoSvc to ActsGeoSvc #12

merged 1 commit into from
Sep 20, 2023

Conversation

Zehvogel
Copy link
Collaborator

BEGINRELEASENOTES

  • Rename GeoSvc to ActsGeoSvc to avoid clash with k4FWcore/GeoSvc

ENDRELEASENOTES

Contains parts of #10

@Zehvogel Zehvogel mentioned this pull request Aug 24, 2023
Open
10 tasks
@andresailer andresailer mentioned this pull request Sep 6, 2023
Merged
@andresailer
Copy link
Contributor

Please rename the IGeoSvc.h file to avoid clashing with k4FWCore's IGeoSvc.h

@Zehvogel Zehvogel merged commit 7050594 into key4hep:main Sep 20, 2023
3 of 4 checks passed
@Zehvogel Zehvogel deleted the gesosvc-rename branch September 20, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer left review comments

@paulgessinger paulgessinger paulgessinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zehvogel @andresailer @paulgessinger