Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI tests and update to newer ACTS #13

Merged
merged 6 commits into from
Oct 17, 2023
Merged

Conversation

Zehvogel
Copy link
Collaborator

@Zehvogel Zehvogel commented Aug 25, 2023

BEGINRELEASENOTES

  • Update CI to include tests builds and geometry loading
  • Update CMake files and code to work with newer ACTS versions

ENDRELEASENOTES

@Zehvogel Zehvogel mentioned this pull request Aug 24, 2023
10 tasks
@andresailer
Copy link
Contributor

Can you add pre-commit and license while you are at it?

@andresailer
Copy link
Contributor

@paulgessinger Are you OK with the Apache 2 License?

@Zehvogel
Copy link
Collaborator Author

Build test is waiting for key4hep/key4hep-spack#522 as Acts is unfortunately built without the dd4hep plugin in key4hep atm..

[lreichen@pcphsft121 acts]$ ll /cvmfs/sw-nightlies.hsf.org/key4hep/releases/2023-06-24/x86_64-centos7-gcc12.2.0-opt/acts/23.2.1-rk7msr/include/Acts/
total 42
-rw-r--r--. 1 cvmfs cvmfs 1036 Jun 25 08:46 ActsVersion.hpp
drwxr-sr-x. 2 cvmfs cvmfs   58 Jun 25 08:48 Clusterization
drwxr-sr-x. 2 cvmfs cvmfs  113 Jun 25 08:48 Definitions
drwxr-sr-x. 2 cvmfs cvmfs  217 Jun 25 08:48 Digitization
drwxr-sr-x. 3 cvmfs cvmfs 4096 Jun 25 08:48 EventData
drwxr-sr-x. 3 cvmfs cvmfs 4096 Jun 25 08:48 Geometry
drwxr-sr-x. 3 cvmfs cvmfs  248 Jun 25 08:48 MagneticField
drwxr-sr-x. 3 cvmfs cvmfs 4096 Jun 25 08:48 Material
drwxr-sr-x. 3 cvmfs cvmfs 4096 Jun 25 08:48 Propagator
drwxr-sr-x. 2 cvmfs cvmfs 4096 Jun 25 08:48 Seeding
drwxr-sr-x. 3 cvmfs cvmfs  120 Jun 25 08:48 SpacePointFormation
drwxr-sr-x. 3 cvmfs cvmfs 4096 Jun 25 08:48 Surfaces
drwxr-sr-x. 2 cvmfs cvmfs  153 Jun 25 08:48 TrackFinding
drwxr-sr-x. 3 cvmfs cvmfs  282 Jun 25 08:48 TrackFitting
drwxr-sr-x. 3 cvmfs cvmfs 4096 Jun 25 08:48 Utilities
drwxr-sr-x. 2 cvmfs cvmfs 4096 Jun 25 08:48 Vertexing
drwxr-sr-x. 3 cvmfs cvmfs  183 Jun 25 08:48 Visualization

@paulgessinger
Copy link
Collaborator

The other PR is merged but it seems like it's still failing to find the the plugin?

@Zehvogel
Copy link
Collaborator Author

We only expect the nightlies to pass and they do now. It will take until the next release for the other one...

@Zehvogel
Copy link
Collaborator Author

currently waiting for the opendatadetector to become available in the nightlies, it should be there tomorrow. Then we can use it directly in the ci without building it ourselves every time

@Zehvogel Zehvogel marked this pull request as draft September 19, 2023 14:42
@Zehvogel Zehvogel changed the title Update CI Add CI tests and update to newer ACTS Sep 20, 2023
@Zehvogel Zehvogel marked this pull request as ready for review September 20, 2023 08:44
@paulgessinger
Copy link
Collaborator

@Zehvogel I see, where is this built then? I'm wondering if keeping this in sync is really worth it since building it does not take a long time normally.

@Zehvogel
Copy link
Collaborator Author

@Zehvogel I see, where is this built then? I'm wondering if keeping this in sync is really worth it since building it does not take a long time normally.

@paulgessinger Is your question where the ODD is built? We added it to the key4hep-stack. At the moment we build the last tagged version, but we could also add it properly to the key4hep nightlies and have the latest main all the time...

@Zehvogel Zehvogel enabled auto-merge (squash) October 17, 2023 14:40
@Zehvogel Zehvogel merged commit a627e58 into key4hep:main Oct 17, 2023
2 of 4 checks passed
@Zehvogel Zehvogel deleted the update-ci branch October 17, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants