Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a .clang-format file and format the repo #66

Closed
wants to merge 1 commit into from

Conversation

AuroraPerego
Copy link

BEGINRELEASENOTES

  • add a .clang-format file and format the repo

ENDRELEASENOTES

Copy link

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this. Since we have a common .clang-format to ensure consistent formatting for all Key4hep repositories, I would prefer if we used that also here, unless there are compelling reasons not to do that.

@AuroraPerego
Copy link
Author

Thanks a lot for this. Since we have a common .clang-format to ensure consistent formatting for all Key4hep repositories, I would prefer if we used that also here, unless there are compelling reasons not to do that.

Oh, I did not know that :)
I just used one I was already using in another place, I can move to this one.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jmcarcell
Copy link
Member

I updated the common .clang-format, reformatted the repository and added the commit to .git-blame-ignore-revs. Can you try to exctract the changes #67 that are not formatting and rebase? I would not try to solve the conflicts, just simply try to apply the changes again (I think it's easier?).

@jmcarcell jmcarcell closed this Mar 23, 2025
@AuroraPerego
Copy link
Author

I updated the common .clang-format, reformatted the repository and added the commit to .git-blame-ignore-revs. Can you try to exctract the changes #67 that are not formatting and rebase? I would not try to solve the conflicts, just simply try to apply the changes again (I think it's easier?).

done!

@AuroraPerego AuroraPerego deleted the clangFormat branch March 24, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants