Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a quick workaround for collection metadata creation #119

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Introduce a quick workaround for collection metadata creation #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9831478
Workaround for coll metadata access in converters
tmadlener Jul 6, 2023
5179d70
Move metadata handle name function upstream to podio
tmadlener Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions k4FWCore/include/k4FWCore/MetaDataHandle.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,6 @@

#include <type_traits>

namespace k4FWCore {

static std::string metaDataHandleDescriptor(const std::string& collectionName, const std::string& key) {
return collectionName + "__" + key;
}

} // namespace k4FWCore

template <typename T> class MetaDataHandle {
public:
MetaDataHandle();
Expand Down Expand Up @@ -88,7 +80,7 @@ template <typename T> void MetaDataHandle<T>::put(T value) {
template <typename T> std::string MetaDataHandle<T>::fullDescriptor() {
std::string full_descriptor;
if (nullptr != m_dataHandle) {
full_descriptor = k4FWCore::metaDataHandleDescriptor(m_dataHandle->objKey(), m_descriptor);
full_descriptor = podio::collMetadataParamName(m_dataHandle->objKey(), m_descriptor);
// remove the "/Event/" part of the collections' object key if in read mode
if (m_mode == Gaudi::DataHandle::Reader) {
full_descriptor.erase(0, 7);
Expand Down
2 changes: 1 addition & 1 deletion k4FWCore/include/k4FWCore/PodioDataSvc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class PodioDataSvc : public DataSvc {
/// Resets caches of reader and event store, increases event counter
void endOfRead();

private:
/// TODO: Make this private again after conversions have been properly solved
podio::Frame& getMetaDataFrame() { return m_metadataframe; }

private:
Expand Down
Loading