Keep looping through configurables

[kjvbrt]

BEGINRELEASENOTES

• k4run: fix error about "dictionary changed size during iteration"

ENDRELEASENOTES

Otherwise, I'm getting the following error with this configuration file.

Traceback (most recent call last):                                                                         
  File "/home/jsmiesko/Work/FCC/k4FWCore/install/bin/k4run", line 140, in <module>                         
    add_arguments(parser, ApplicationMgr())                                                                
  File "/home/jsmiesko/Work/FCC/k4FWCore/install/bin/k4run", line 32, in add_arguments                     
    for conf in configurables:                                                                             
RuntimeError: dictionary changed size during iteration

Nota bene: The configuration file has also other problems :)

[Zehvogel]

Interesting, we should probably at least honour this particularity it with a comment then.
Do you have an idea why this happens? Can we come up with a smaller reproducer for this?

[kjvbrt]

From the print debugging I would say that when the algorithm with tools is added its tools are added to the list of configurables

11:31:06 [jsmiesko@carriacou k4RecCalorimeter (main =)]$ k4run RecFCCeeCalorimeter/tests/options/runCaloSim.py 
-------------------------------------------------
<bound method Configurable.name of ApplicationMgr('ApplicationMgr')>
-------------------------------------------------
<bound method Configurable.name of FCCDataSvc('EventDataSvc')>
configurables num. of elemets: 37
dict_values([ApplicationMgr('ApplicationMgr'), FCCDataSvc('EventDataSvc'), MomentumRangeParticleGun('ToolSvc.MomentumRangeParticleGun'), GenAlg('GenAlg'), MomentumRangeParticleGun('GenAlg.MomentumRangeParticleGun'), HepMCToEDMConverter('Converter'), GeoSvc('GeoSvc'), SimG4Svc('SimG4Svc'), SimG4ConstantMagneticFieldTool('ToolSvc.SimG4ConstantMagneticFieldTool'), SimG4SaveCalHits('ToolSvc.saveECalBarrelHits'), SimG4Alg('SimG4Alg'), SimG4SaveCalHits('ToolSvc.saveECalEndcapHits'), SimG4SaveCalHits('ToolSvc.saveHCalBarrelHits'), SimG4PrimariesFromEdmTool('ToolSvc.EdmConverter'), SimG4PrimariesFromEdmTool('SimG4Alg.EdmConverter'), CalibrateInLayersTool('ToolSvc.CalibrateECalBarrel'), CalibrateCaloHitsTool('ToolSvc.CalibrateHCal'), CalibrateCaloHitsTool('ToolSvc.CalibrateECalEndcap'), CreateCaloCells('CreateECalBarrelCellsStep1'), CalibrateInLayersTool('CreateECalBarrelCellsStep1.CalibrateECalBarrel'), RedoSegmentation('ReSegmentationEcal'), CreateCaloCells('CreateECalBarrelCells'), CellPositionsECalBarrelTool('ToolSvc.CellPositionsECalBarrel'), CreateCaloCellPositionsFCCee('ECalBarrelPositionedCells'), CreateCaloCells('CreateHCaloCells'), CalibrateCaloHitsTool('CreateHCaloCells.CalibrateHCal'), CreateCaloCells('CreateEcalEndcapCaloCells'), CalibrateCaloHitsTool('CreateEcalEndcapCaloCells.CalibrateECalEndcap'), CreateEmptyCaloCellsCollection('CreateEmptyCaloCells'), CaloTowerTool('ToolSvc.towers'), CreateCaloClustersSlidingWindow('CreateClusters'), CreateCaloCellPositionsFCCee('ECalBarrelPositionedCaloClusterCells'), CorrectCaloClusters('correctCaloClusters'), PodioOutput('out'), ChronoAuditor('ChronoAuditor'), AuditorSvc('AuditorSvc'), EventCounter('event_counter')])
-------------------------------------------------
<bound method Configurable.name of MomentumRangeParticleGun('ToolSvc.MomentumRangeParticleGun')>
-------------------------------------------------
<bound method Configurable.name of GenAlg('GenAlg')>
configurables num. of elemets: 41
dict_values([ApplicationMgr('ApplicationMgr'), FCCDataSvc('EventDataSvc'), MomentumRangeParticleGun('ToolSvc.MomentumRangeParticleGun'), GenAlg('GenAlg'), MomentumRangeParticleGun('GenAlg.MomentumRangeParticleGun'), HepMCToEDMConverter('Converter'), GeoSvc('GeoSvc'), SimG4Svc('SimG4Svc'), SimG4ConstantMagneticFieldTool('ToolSvc.SimG4ConstantMagneticFieldTool'), SimG4SaveCalHits('ToolSvc.saveECalBarrelHits'), SimG4Alg('SimG4Alg'), SimG4SaveCalHits('ToolSvc.saveECalEndcapHits'), SimG4SaveCalHits('ToolSvc.saveHCalBarrelHits'), SimG4PrimariesFromEdmTool('ToolSvc.EdmConverter'), SimG4PrimariesFromEdmTool('SimG4Alg.EdmConverter'), CalibrateInLayersTool('ToolSvc.CalibrateECalBarrel'), CalibrateCaloHitsTool('ToolSvc.CalibrateHCal'), CalibrateCaloHitsTool('ToolSvc.CalibrateECalEndcap'), CreateCaloCells('CreateECalBarrelCellsStep1'), CalibrateInLayersTool('CreateECalBarrelCellsStep1.CalibrateECalBarrel'), RedoSegmentation('ReSegmentationEcal'), CreateCaloCells('CreateECalBarrelCells'), CellPositionsECalBarrelTool('ToolSvc.CellPositionsECalBarrel'), CreateCaloCellPositionsFCCee('ECalBarrelPositionedCells'), CreateCaloCells('CreateHCaloCells'), CalibrateCaloHitsTool('CreateHCaloCells.CalibrateHCal'), CreateCaloCells('CreateEcalEndcapCaloCells'), CalibrateCaloHitsTool('CreateEcalEndcapCaloCells.CalibrateECalEndcap'), CreateEmptyCaloCellsCollection('CreateEmptyCaloCells'), CaloTowerTool('ToolSvc.towers'), CreateCaloClustersSlidingWindow('CreateClusters'), CreateCaloCellPositionsFCCee('ECalBarrelPositionedCaloClusterCells'), CorrectCaloClusters('correctCaloClusters'), PodioOutput('out'), ChronoAuditor('ChronoAuditor'), AuditorSvc('AuditorSvc'), EventCounter('event_counter'), ConstPileUp('GenAlg.PileUpTool'), FlatSmearVertex('GenAlg.VertexSmearingTool'), HepMCSimpleMerge('GenAlg.HepMCMergeTool'), MomentumRangeParticleGun('GenAlg.HepMCProviderTool')])
Traceback (most recent call last):
  File "/home/jsmiesko/Work/FCC/k4FWCore/install/bin/k4run", line 139, in <module>
    add_arguments(parser, ApplicationMgr())
  File "/home/jsmiesko/Work/FCC/k4FWCore/install/bin/k4run", line 31, in add_arguments
    for conf in configurables:
RuntimeError: dictionary changed size during iteration

[Zehvogel]

Looks like all the tools that an algorithm can have are added when ´.getPropertiesWithDescription()´ gets called, not only the ones explicitly set?

We could also think about looping twice to add all of the tools' properties to the arguments as well, if anyone wants that..

I would really like to have a small test algorithm in this repo that shows the same behavior as e.g. GenAlg but that can be added later and should not keep us from merging this.

[kjvbrt]

Thanks