Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sliding-window clustering for Theta-Module readout #158

Merged
merged 18 commits into from
Feb 9, 2024

Conversation

dasphy
Copy link
Contributor

@dasphy dasphy commented Nov 8, 2023

Hello,
I create this PR for making sliding-window clustering work with Theta-Module readout.
Please help me review the code, thank you!

Related PRs:
HEP-FCC/k4RecCalorimeter#58
BrieucF/LAr_scripts#16

@BrieucF
@giovannimarchiori
@gartrog

Cheers,
Tong Li

@dasphy
Copy link
Contributor Author

dasphy commented Dec 8, 2023

Hello @vvolkl @BrieucF @kjvbrt,
In this PR I added a new file "k4Interface/ITowerToolThetaModule.h" for SW clustering at FCCee,
where CaloTower is created from theta-phi that is different from eta-phi segmentation at FCChh.
Please have a look, thank you.

@gartrog
@giovannimarchiori

Cheers, Tong

@kjvbrt
Copy link
Contributor

kjvbrt commented Jan 24, 2024

Hello @dasphy, can you remove the struct tower from this interface?
Similarly to the #175

@jmcarcell jmcarcell enabled auto-merge (squash) February 9, 2024 09:08
@jmcarcell jmcarcell merged commit 8c4fbb5 into key4hep:main Feb 9, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants